fix: pull latest image from registry when using build server #4771
Conversation
|
@coderabbitai review |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request updates the Docker Compose command within the Changes
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/Jobs/ApplicationDeploymentJob.php (1)
2267-2279: Consider adding--pull alwaysin other Docker Compose commands for consistency.While the change fixes the issue for build server deployments, consider adding the
--pull alwaysflag in other Docker Compose commands for consistency:
- Line 2277: When not using a build server, the images might not be pulled if they exist locally.
Note: The dockerimage buildpack case (line 2268) already has a separate pull command, so it's not affected.
Apply this diff to ensure consistent behavior:
- [executeInDocker($this->deployment_uuid, "{$this->coolify_variables} docker compose --project-name {$this->application->uuid} --project-directory {$this->workdir} -f {$this->workdir}{$this->docker_compose_location} up --build -d"), 'hidden' => true], + [executeInDocker($this->deployment_uuid, "{$this->coolify_variables} docker compose --project-name {$this->application->uuid} --project-directory {$this->workdir} -f {$this->workdir}{$this->docker_compose_location} up --pull always --build -d"), 'hidden' => true],
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/Jobs/ApplicationDeploymentJob.php(1 hunks)
🔇 Additional comments (1)
app/Jobs/ApplicationDeploymentJob.php (1)
2273-2274: LGTM! The change ensures latest images are pulled.The addition of
--pull alwaysto the Docker Compose command ensures that the latest container images are always pulled from the registry before starting containers, which fixes the issue with preview images not being pulled when using a build server.
|
Thank you for the PR! |
Changes
Issues